feat(windows): Add support for booting Windows on arm64#1542
Closed
ashlcx wants to merge 4 commits intonetbootxyz:developmentfrom
ashlcx:development
Closed
feat(windows): Add support for booting Windows on arm64#1542ashlcx wants to merge 4 commits intonetbootxyz:developmentfrom ashlcx:development
ashlcx wants to merge 4 commits intonetbootxyz:developmentfrom
ashlcx:development
Conversation
antonym
reviewed
Dec 4, 2024
|
|
||
| :arch_set | ||
| iseq ${win_arch} x64 && set win_arch x86 || set win_arch x64 | ||
| iseq ${win_arch} x64 && set win_arch x86 && set win_arch arm64 || set win_arch x64 |
Member
There was a problem hiding this comment.
This logic may not work well, as it's flipping between x86 and arm64, so x86 will probably never get set.
Author
There was a problem hiding this comment.
Ah yeah good point, I'll add in automatic arch detection and a seperate menu as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for booting Windows on arm64 using wimboot.arm64